-
Notifications
You must be signed in to change notification settings - Fork 108
feat(clientdata): id
is now optional on clientdata.output_*()
methods
#1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ently executing output
…ut an id inside an output renderer
d7e3815
to
088ef7b
Compare
088ef7b
to
e97b0f0
Compare
current_output_id
attribute and make id optional on clientdata
output methods.current_output_id()
method and make id
optional on clientdata.output_*()
methods
.current_output_id()
method and make id
optional on clientdata.output_*()
methodsid
is now optional on clientdata.output_*()
methods
@schloerke my memory is a little fuzzy, but I think we had agreed this was OK as is? |
It is good, but I do not want to alter I'm almost done with a fix. |
@cpsievert This is ready to go. Please take a look at the changes. Changes:
|
@cpsievert There's an unrelated failure from shinytemplates (@karangattu is fixing) that is preventing auto merging. Please admin merge when ready. |
Ahh, thank you for the fixes!! 🍻 |
See the changes to
CHANGELOG
for a description of what this PR adds.A minimal example: