fix(pkg-r): better support for modules. #172
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
This PR introduces proper namespace handling for QueryChat within Shiny (for R) modules:
Changes to
$ui()and$sidebar()methods:nsparameter: Users can now explicitly pass a Shiny namespacing function (shiny::NS()) when calling these methods within a module UI functionrenderUI()), the namespace is automatically inferred from the sessioniddirectly, with helpful error messages guiding them to usensinsteadImplementation details:
namespaced_id()helper function that checks for a reactive domain and applies namespacing when availableidfield to clarify it's an instance ID rather than specifically a module IDnsargumentUsage
When using QueryChat in a module UI function, pass the namespacing function:
When using
renderUI()in a module server, the namespacing is automatic: