feat(pkg-py): Python tool displays v2 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
feat/python-tool-displays-v2
branch
from
39c3369 to
174ff3f
Compare
cpsievert
force-pushed
the
feat/python-tool-displays-v2
branch
from
d87e3a0 to
d5fdb96
Compare
gadenbuie
approved these changes
Sep 3, 2025
Collaborator
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
This looks great! I didn't read it in great detail, but I read through the changes and everything is very nicely organized and clean. I really like the way that ToolResultComponent and ToolResultDisplay are set up, it composes nicely.
I'm okay with merging this; I'll try to update Python querychat soon to use these features, which will give me a chance to try them out. We can follow up then with any feedback.
This was referenced Sep 4, 2025
gadenbuie
added a commit
that referenced
this pull request
Sep 9, 2025
…tml display (#127) * Follow up to #107: pick up tool annotation icon and never escape icon or html display * chore: make py-format --------- Co-authored-by: Garrick Aden-Buie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the new, more customizable, tool calling displays (already added to R in #52) over to Python.
In order to make use of it, you'll need the latest chatlas (if you don't have the latest, you'll get the legacy displays):
Also note that the manual testing apps added in #52 (under
pkg-r/tests/testthat/apps) have been ported over (underpkg-py/tests/playwright/tools) and used for testing. It'd be great to automate some tests here, but @gadenbuie has requested that we wait post-conf (and focus instead on shipping other needed features)TODO
Review, merge, and release a fix for bookmarking custom displays fix: makeContentToolResult'sextraaware of shinychat'sdisplayfeature (for bookmarking) chatlas#167