-
Notifications
You must be signed in to change notification settings - Fork 15
feat(pkg-py): Add new message_content()
and message_content_chunk()
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0552907
to
b7edff7
Compare
…hinychat_chunk() These new functions are the singledispatch equivalent of the previous normalize_message() and normalize_message_chunk(). Although not quite as flexible as the previous strategies pattern, it's much simpler (implementation wise and also for those registering new methods) and aligns much better with the vision for the R package
b7edff7
to
a30a722
Compare
Co-authored-by: Copilot <[email protected]>
contents_shinychat()
and contents_shinychat_chunk()
get_message_content()
and get_message_chunk_content()
0bcbcd0
to
ba7e201
Compare
Co-authored-by: Copilot <[email protected]>
4be7753
to
f4a6950
Compare
f4a6950
to
959fb61
Compare
get_message_content()
and get_message_chunk_content()
message_content()
and message_chunk_content()
gadenbuie
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just one small name adjustment comment. Thanks!
message_content()
and message_chunk_content()
message_content()
and message_content_chunk()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
message_content()
andmessage_content_chunk()
generic functions (viasingledispatch
). They aren't intended to be called directly by users, but instead, provide an opportunity to teachChat.append_message()
/Chat.append_message_stream()
how to extract aChatMessage()
from different bespoke objects.These new functions are the
singledispatch
equivalent of the previous (internal)normalize_message()
andnormalize_message_chunk()
helpers. Although not quite as flexible as the previous strategies pattern, this approach much simpler (implementation wise and also for those registering new methods) and aligns much better withshinychat::contents_shinychat()
(#52).