Skip to content

Fix `Digest::CRC16DNP #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix `Digest::CRC16DNP #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/digest/crc16_dnp/crc16_dnp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ crc16_t crc16_dnp_update(crc16_t crc, const void *data, size_t data_len)
while (data_len--)
{
tbl_idx = (crc ^ *d) & 0xff;
crc = (crc << 8) ^ crc16_dnp_table[tbl_idx];
crc = (crc >> 8) ^ crc16_dnp_table[tbl_idx];
d++;
}

Expand Down
6 changes: 2 additions & 4 deletions lib/digest/crc16_dnp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ class CRC16DNP < CRC16

INIT_CRC = 0

XOR_MASK = 0xffff

TABLE = [
0x0000, 0x365e, 0x6cbc, 0x5ae2, 0xd978, 0xef26, 0xb5c4, 0x839a,
0xff89, 0xc9d7, 0x9335, 0xa56b, 0x26f1, 0x10af, 0x4a4d, 0x7c13,
Expand Down Expand Up @@ -57,10 +59,6 @@ def update(data)
return self
end

def finish
self.class.pack(~@crc)
end

end
end

Expand Down
10 changes: 10 additions & 0 deletions spec/crc16_dnp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
require 'spec_helper'
require 'crc_examples'
require 'digest/crc16_dnp'

describe Digest::CRC16DNP do
let(:string) { '1234567890' }
let(:expected) { 'bc1b' }

it_should_behave_like "CRC"
end