Skip to content

Conversation

Anoesj
Copy link
Contributor

@Anoesj Anoesj commented Aug 14, 2025

Enabled "Format on save" and sets Prettier to be the default formatter for JS/TS/JSON.

Summary by CodeRabbit

  • Chores
    • Standardized editor configuration to auto-format files on save in supported editors.
    • Set Prettier as the default formatter for TypeScript, JavaScript, and JSON.
    • Retained existing Prettier and TypeScript integration settings.
    • No impact on application behavior or user-facing features.

Copy link

coderabbitai bot commented Aug 14, 2025

Walkthrough

Added VSCode workspace settings to enable format-on-save and set Prettier as the default formatter for TypeScript, JavaScript, and JSON. Existing Prettier and TypeScript settings remain unchanged.

Changes

Cohort / File(s) Summary
VSCode settings and formatting
/.vscode/settings.json
Enable editor.formatOnSave; set default formatter to esbenp.prettier-vscode for TypeScript, JavaScript, and JSON; retain existing prettier.enable, typescript.tsdk, and related preferences.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Aug 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/unplugin-vue-router@699

commit: ea3c0a6

@Anoesj Anoesj force-pushed the chore/vscode-format-with-prettier branch from 9c59b4b to ea3c0a6 Compare August 14, 2025 10:44
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.90%. Comparing base (44f833b) to head (ea3c0a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   60.90%   60.90%           
=======================================
  Files          36       36           
  Lines        3379     3379           
  Branches      618      618           
=======================================
  Hits         2058     2058           
  Misses       1314     1314           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
.vscode/settings.json (3)

7-7: Reduce churn with formatOnSaveMode=modifications

This limits formatting to changed lines when supported, minimizing noisy diffs.

   "editor.formatOnSave": true,
+  "editor.formatOnSaveMode": "modifications",

8-13: Cover React flavors too (TSX/JSX)

Add typescriptreact and javascriptreact to keep Prettier consistent across TSX/JSX.

   "[typescript]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode",
   },
+  "[typescriptreact]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+  },
   "[javascript]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode",
   },
+  "[javascriptreact]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+  },

14-17: Also apply to jsonc (VSCode config, tsconfig with comments)

settings.json and many config files are jsonc in VS Code; set Prettier for jsonc too.

   "[json]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode",
   },
+  "[jsonc]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+  },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 44f833b and ea3c0a6.

📒 Files selected for processing (1)
  • .vscode/settings.json (1 hunks)
🔇 Additional comments (1)
.vscode/settings.json (1)

7-17: LGTM: Format-on-save with Prettier matches the PR goal

Enabling format-on-save and setting Prettier as the default formatter for JS/TS/JSON aligns with the PR objective. No functional risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant