Skip to content

Conversation

@SakshiJain0302
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@SonalMahambrey1
Copy link

looks good to me

@shivansh-ibm
Copy link
Contributor

@shubham-dayma-ibm ,please review and accept the changes

# Variables
PACKAGE_NAME=pyarrow
PACKAGE_VERSION=${1:-apache-arrow-15.0.1}
PACKAGE_VERSION=${1:-apache-arrow-14.0.1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have to rename the build-script and update the build-info.json? build-info.json should always points to the latest version. Please revert the change. Keep cython==0.29.36 change and make sure it works for both 14.0.1 and 15.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rename file to latest UBI version(from pyarrow_15.0.1_ubi_9.3.sh to pyarrow_15.0.1_ubi_9.6.sh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants