Disable onChange and route() during SSR #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendered via `preact-render-to-string`, `onChange` and `route()` both don't make sense - updates can't be rendered since rendering is synchronous and single-pass, so we'll just disable this functionality entirely.
kristoferbaxter
approved these changes
Aug 10, 2019
marvinhagemeister
approved these changes
Aug 10, 2019
developit
commented
Oct 21, 2019
developit
commented
Oct 21, 2019
developit
commented
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendered via
preact-render-to-string,onChangeandroute()both don't make sense - updates can't be rendered since rendering is synchronous and single-pass, so we'll just disable this functionality entirely./cc @kristoferbaxter