Skip to content

Cheking urls considering protocol-relative url #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cheking urls considering protocol-relative url #383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9142368
Cheking urls considering protocol-relative url
Sep 25, 2020
cdbcf6e
Merge branch 'master' into master
18choi18 Oct 4, 2020
8485dec
Merge branch 'master' into master
18choi18 Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function routeFromLink(node) {
target = node.getAttribute('target');

// ignore links with targets and non-path URLs
if (!href || !href.match(/^\//g) || (target && !target.match(/^_?self$/i))) return;
if (!href || !href.match(/^\/(?!\/)/g) || (target && !target.match(/^_?self$/i))) return;

// attempt to route, if no match simply cede control to browser
return route(href);
Expand Down