feat: git source test #56
Conversation
remimimimimi
force-pushed
the
feat/git-source-test
branch
from
30ad6d1 to
64e3f95
Compare
|
Sorry @remimimimimi we already changed the way this works 😇 |
remimimimimi
force-pushed
the
feat/git-source-test
branch
from
64e3f95 to
5b93fac
Compare
|
can we remove the |
remimimimimi
force-pushed
the
feat/git-source-test
branch
from
5cb5755 to
64c932e
Compare
| version = "0.1.0" | ||
|
|
||
| [package.build] | ||
| source = { git = "https://github.com/prefix-dev/pixi-build-testsuite.git", rev = "ee87916a49d5e96d4f322f68c3650e8ff6b8866b", subdirectory = "tests/data/pixi_build/cpp-with-path-to-source/project" } |
There was a problem hiding this comment.
It should be possible to point to a git directory via a path.
That way we don't have to make a network request and the test will run faster
There was a problem hiding this comment.
Also, let's use the much simpler tests/data/pixi_build/minimal-backend-workspaces/pixi-build-cmake/ instead
| channels = [ | ||
| "https://prefix.dev/pixi-build-backends", | ||
| "https://prefix.dev/conda-forge", | ||
| ] |
There was a problem hiding this comment.
The backend will be overriden anyway so no need to specify channels for it
| channels = [ | |
| "https://prefix.dev/pixi-build-backends", | |
| "https://prefix.dev/conda-forge", | |
| ] |
| @pytest.mark.slow | ||
| def test_git_path(pixi: Path, build_data: Path, tmp_pixi_workspace: Path) -> None: | ||
| """ | ||
| Test git path in `[package.build.source]` | ||
| """ | ||
| project = "cpp-with-git-source" | ||
| test_data = build_data.joinpath(project) | ||
|
|
||
| shutil.copytree(test_data, tmp_pixi_workspace, dirs_exist_ok=True, copy_function=shutil.copy) | ||
|
|
||
| verify_cli_command( | ||
| [ | ||
| pixi, | ||
| "build", | ||
| "-v", | ||
| "--manifest-path", | ||
| tmp_pixi_workspace, | ||
| "--output-dir", | ||
| tmp_pixi_workspace, | ||
| ], | ||
| ) | ||
|
|
||
| # Ensure that exactly one conda package has been built | ||
| built_packages = list(tmp_pixi_workspace.glob("*.conda")) | ||
| assert len(built_packages) == 1 |
There was a problem hiding this comment.
I think it makes more sense to make the test similar to this:
pixi-build-testsuite/tests/integration_python/test_backends.py
Lines 20 to 35 in c37aa75
That way you test that the package actually works
remimimimimi
force-pushed
the
feat/git-source-test
branch
2 times, most recently
from
f1abaf2 to
f6b86c4
Compare
remimimimimi
force-pushed
the
feat/git-source-test
branch
from
fea6593 to
f522682
Compare
3 participants
Tests for prefix-dev/pixi#4446.