fix: save glob-root for correct rebuilds #4839
Draft
+84
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
changed the title
tdejager
commented
Oct 28, 2025
| /// E.g we are building from `package.build.source.path = "../"` we want | ||
| /// to resolve globs from that location | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub glob_root: Option<PathBuf>, |
There was a problem hiding this comment.
This is the new field.
tdejager
commented
Oct 28, 2025
| alias = "source_code_root", | ||
| alias = "input_root" | ||
| )] | ||
| pub glob_root: Option<PathBuf>, |
tdejager
commented
Oct 28, 2025
| return Ok(Some(metadata)); | ||
| }; | ||
|
|
||
| let Some(cached_root) = metadata.glob_root.as_ref() else { |
There was a problem hiding this comment.
Here we regenerate if its not found.
tdejager
commented
Oct 28, 2025
| .await | ||
| .map_err_with(SourceBuildCacheStatusError::SourceCheckout)?; | ||
|
|
||
| let Some(glob_root) = source_info.glob_root.as_ref().cloned() else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix: #4837
We now save the
glob-root, so where need to start globbing for the file for changes. We save this in the metadata cache, this does invalidate the current entries though, we could also opt to version it to v-2. Wdyt?