Skip to content

Conversation

@nichmor
Copy link
Contributor

@nichmor nichmor commented Oct 27, 2025

small overview about the update

One small thing that needs some more testing is the addition of build_isolation method in BuildContext trait. It faces the same problem with interpreter - we need first to initialise our lazy dispatch to ask for the build_isolation from it. The problem is that this method is not async, and we need to use runtime::block_on or make an upstream contribution similar to interpreter to make it async.
The thing is, while interpreter makes some sense to be async, I think build_isolation has less chance to be accepted. Maybe while testing, we will not face that deadlock issue, and the contribution will not be necessary.

@lucascolley lucascolley added uv Related to the uv integration dependencies labels Oct 27, 2025
@tdejager
Copy link
Contributor

I think as long as 'build_isolation' is called after 'interpreter' it should be okay. But if it's not then it's gonna be a problem.

Maybe add some log statements and check the situation?

@tdejager
Copy link
Contributor

Also we could try adding the conda activation to the ExtraBuildVars then we do not need the other method for it? Could you give that a go?

@nichmor
Copy link
Contributor Author

nichmor commented Oct 28, 2025

Also we could try adding the conda activation to the ExtraBuildVars then we do not need the other method for it? Could you give that a go?

I think it is a different use case - for us, conda activation is per entire environment, where ExtraBuildVars accepts something on a per-package basis.

That's why we are using build_extra_env_vars

@nichmor
Copy link
Contributor Author

nichmor commented Oct 28, 2025

@tdejager tested on multiple pypi examples from our repository - works as expected

@tdejager
Copy link
Contributor

Also we could try adding the conda activation to the ExtraBuildVars then we do not need the other method for it? Could you give that a go?

I think it is a different use case - for us, conda activation is per entire environment, where ExtraBuildVars accepts something on a per-package basis.

That's why we are using build_extra_env_vars

We added that method to uv for our use-case, it should be the same thing. Similarly to rattler-build the build is isolated so there is an activation per package so to say. You can't really speak about an environment in that sense, that only means something with no-build-isolation. I think it will just work 😀

@nichmor nichmor added the test:extra_slow Run the extra slow tests label Oct 29, 2025
@tdejager
Copy link
Contributor

So @nichmor and myself discussed, and I better got what was meant. We can support and integrate their API per package after the upgrade, if we get a request for it :) We do have something similar for pixi-build.

@nichmor nichmor enabled auto-merge (squash) October 29, 2025 09:37
@nichmor nichmor merged commit 06d1281 into prefix-dev:main Oct 29, 2025
38 checks passed
Hofer-Julian pushed a commit that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies test:extra_slow Run the extra slow tests uv Related to the uv integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants