-
Notifications
You must be signed in to change notification settings - Fork 388
chore: upgrade uv to 0.9.5 #4840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think as long as 'build_isolation' is called after 'interpreter' it should be okay. But if it's not then it's gonna be a problem. Maybe add some log statements and check the situation? |
|
Also we could try adding the conda activation to the ExtraBuildVars then we do not need the other method for it? Could you give that a go? |
I think it is a different use case - for us, conda activation is per entire environment, where That's why we are using |
|
@tdejager tested on multiple |
We added that method to uv for our use-case, it should be the same thing. Similarly to rattler-build the build is isolated so there is an activation per package so to say. You can't really speak about an environment in that sense, that only means something with no-build-isolation. I think it will just work 😀 |
|
So @nichmor and myself discussed, and I better got what was meant. We can support and integrate their API per package after the upgrade, if we get a request for it :) We do have something similar for |
small overview about the update
ExtraBuildVariables, which is related to this functionality: https://docs.astral.sh/uv/reference/settings/#extra-build-variables. Something we can also support laterFilestruct, which is supported bypyxfrom astral ( related PR Add zstandard support for wheels astral-sh/uv#15645 )One small thing that needs some more testing is the addition of
build_isolationmethod in BuildContext trait. It faces the same problem withinterpreter- we need first to initialise our lazy dispatch to ask for the build_isolation from it. The problem is that this method is not async, and we need to useruntime::block_onor make an upstream contribution similar tointerpreterto make it async.The thing is, while
interpretermakes some sense to be async, I thinkbuild_isolationhas less chance to be accepted. Maybe while testing, we will not face that deadlock issue, and the contribution will not be necessary.