Fix EXPLAIN ANALYZE with CTE materialization #25810
Open
+9,256
−1,431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Bootstrap tooltip initialization in QueryList component's componentDidMount method to ensure tooltips display at correct position instead of top-left corner. Fixes prestodb#24727
…23798 where EXPLAIN ANALYZE failed on queries with CTE\nmaterialization due to expecting only one sub stage.\n\nChanges:\n- Modified ExplainAnalyzeOperator to support multiple sub stages\n- Added generateTextPlanForSubStages and generateJsonPlanForSubStages methods\n- Added test case for CTE materialization with EXPLAIN ANALYZE\n\nResolves: prestodb#23798
yangbin09
requested review from
a team,
ClarenceThreepwood,
elharo,
feilong-liu,
jaystarshot and
yhwang
as code owners
|
Hi @tdcmeehan @, quick context:
|
|
@yangbin09 thanks for your contribution! Please take a look at the compilation failure. This approach looks good to me. CC: @jaystarshot |
yangbin09
force-pushed
the
fix-explain-analyze-cte-materialization
branch
from
a2dbb72 to
8d11215
Compare
…-cte-materialization
- Fix left brace placement for testViewWithUUID, testExplainAnalyzeWithCTEMaterialization, and assertExplainAnalyze methods - Split long lines to comply with 80-character limit - Add proper Javadoc comments - Remove trailing whitespace
yangbin09
force-pushed
the
fix-explain-analyze-cte-materialization
branch
from
b2e04ec to
2864942
Compare
- Changed parameter name from 'transaction' to 'transactionHandle' in getMetadata method - This fixes the @OverRide annotation error that was causing compilation failure - The parameter name must match the interface definition in Connector.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #23798 where EXPLAIN ANALYZE failed on queries with CTE materialization due to expecting only one sub stage.
Problem
The
ExplainAnalyzeOperatorhad a strict check that expected exactly one sub-stage for explain nodes. However, when CTE materialization is enabled, multiple sub-stages are generated, causing the operator to fail with the error "Expected one sub stage of explain node".Solution
ExplainAnalyzeOperatorto support multiple sub stagesgenerateTextPlanForSubStagesmethod to handle multiple sub-stages for TEXT formatgenerateJsonPlanForSubStagesmethod to handle multiple sub-stages for JSON formatTesting
testExplainAnalyzeWithCTEMaterializationto verify the fixFiles Changed
presto-main-base/src/main/java/com/facebook/presto/operator/ExplainAnalyzeOperator.javapresto-main/src/test/java/com/facebook/presto/operator/TestExplainAnalyzeOperator.javaResolves: #23798