Fix UTF-8 character corruption at 8KB buffer boundaries in socket communication #1461
+81
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatting Ruby code containing multibyte UTF-8 characters (emojis, Japanese characters,
etc.), the plugin corrupts these characters if they happen to fall exactly at the 8192-byte (8KB)
boundary in the data stream between the Node.js plugin and Ruby server.
This issue likely originated from commit bd96faf (July 8, 2023) when the socket reading logic was
changed to fix JSON parsing for large data. The change may have inadvertently introduced a UTF-8
boundary issue where multibyte characters could be split across chunk boundaries.
Reproduction
The emoji gets corrupted because it starts at byte 8189 and is split across the 8KB boundary.
Solution
Implemented a length-prefixed protocol for socket communication:
Testing
Added comprehensive test coverage:
Impact