Skip to content

Conversation

joshblack
Copy link
Member

When styles downstream in Primer React interact with an icon, and .octicon is present on the page, the .octicon call will take precedence since it is in the anonymous layer and Primer React styles are brought in through the primer-react layer.

This change updates the .octicon class to be wrapped in a @layer named primer.icons. We should make sure this layer appears first to avoid any overrides in the future.

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 15:24
@joshblack joshblack requested a review from a team as a code owner May 9, 2025 15:24
@joshblack joshblack requested a review from emilybrick May 9, 2025 15:24
Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: ccd66d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new CSS layer to encapsulate octicon styles and ensure they take precedence over downstream Primer React styles.

  • Wraps the .octicon class in a @layer primer.icons block.
  • Guarantees the primer.icons layer is first to avoid unintended overrides.

@github-actions github-actions bot temporarily deployed to Storybook Preview May 9, 2025 15:27 Inactive
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Jul 8, 2025
@github-actions github-actions bot closed this Jul 15, 2025
@github-actions github-actions bot deleted the joshblack-patch-1 branch July 15, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Automatically marked as stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant