-
Notifications
You must be signed in to change notification settings - Fork 622
Update Dialog/Dialog.features.stories.tsx to no longer use styled-components #6410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
…mponents Co-authored-by: joshblack <[email protected]>
Dialog/Dialog.features.stories.tsx
to no longer use styled-components
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
This PR migrates the Dialog features stories away from styled-components usage as part of the broader effort to remove styled-components from the codebase for performance improvements.
Changes Made
Replaced styled-components with CSS Modules
Dialog.features.stories.module.css
with CSS classes using proper CSS variables for themingBox
components with standard HTMLdiv
elementsText
components withsx
props with standard HTMLp
elementssx
prop usage toclassName
props referencing CSS module classesMaintained Visual Consistency
The migration preserves the exact visual appearance by mapping styled-components theme values to their corresponding CSS variables:
accent.subtle
→var(--bgColor-accent-muted)
danger.subtle
→var(--bgColor-danger-muted)
attention.subtle
→var(--bgColor-attention-muted)
var(--text-body-size-small)
var(--base-size-*)
Key Story Updates
Box bg="accent.subtle"
withdiv className={classes.CustomHeaderBg}
Dialog.Body
content in a div with danger background stylingDialog.Footer
content in a div with attention background stylingBox
components with semanticdiv
elementsText
components to standardp
elementsAll functionality remains identical while completely removing styled-components dependencies from the story file.
Fixes #6409.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.