-
Notifications
You must be signed in to change notification settings - Fork 622
Update AvatarStack.dev.stories.tsx to no longer use styled-components #6437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes styled-components usage from AvatarStack development stories by eliminating the SxProp
story that demonstrated the sx
prop functionality. The change aligns with the broader effort to move away from styled-components in the codebase.
- Removed the
SxProp
story fromAvatarStack.dev.stories.tsx
- Updated the end-to-end test configuration to remove the corresponding test case
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/AvatarStack/AvatarStack.dev.stories.tsx | Removed the SxProp story that demonstrated styled-components functionality |
e2e/components/AvatarStack.test.ts | Removed the test configuration entry for the deleted SxProp story |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note for dev stories, I think we'll hold off on removing them until we remove the sx
support in the component since they're being used in our e2e tests at the moment.
Let me know what you think / if this makes sense or not 👀
Oh yeah, that makes sense! We can just let this PR sit for now, in that case 😸 |
Closes https://github.com/github/primer/issues/5591
Changelog
Changed
Changed
AvatarStack.dev.stories.tsx
to no longer use styled-componentsRemoved
Removed the
Sx Prop
story forAvatarStack
because it no longer has a purpose after removal ofsx
propRollout strategy
Testing & Reviewing
Merge checklist