Skip to content

Update AvatarStack.dev.stories.tsx to no longer use styled-components #6437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Aug 1, 2025

Closes https://github.com/github/primer/issues/5591

Changelog

Changed

Changed AvatarStack.dev.stories.tsx to no longer use styled-components

Removed

Removed the Sx Prop story for AvatarStack because it no longer has a purpose after removal of sx prop

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

This comment was marked as resolved.

@llastflowers llastflowers self-assigned this Aug 1, 2025
@llastflowers llastflowers added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Aug 1, 2025
Copy link
Contributor

github-actions bot commented Aug 1, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.03 KB (0%)
packages/react/dist/browser.umd.js 90.13 KB (0%)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes styled-components usage from AvatarStack development stories by eliminating the SxProp story that demonstrated the sx prop functionality. The change aligns with the broader effort to move away from styled-components in the codebase.

  • Removed the SxProp story from AvatarStack.dev.stories.tsx
  • Updated the end-to-end test configuration to remove the corresponding test case

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/AvatarStack/AvatarStack.dev.stories.tsx Removed the SxProp story that demonstrated styled-components functionality
e2e/components/AvatarStack.test.ts Removed the test configuration entry for the deleted SxProp story

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note for dev stories, I think we'll hold off on removing them until we remove the sx support in the component since they're being used in our e2e tests at the moment.

Let me know what you think / if this makes sense or not 👀

@llastflowers
Copy link
Contributor Author

One note for dev stories, I think we'll hold off on removing them until we remove the sx support in the component since they're being used in our e2e tests at the moment.

Let me know what you think / if this makes sense or not 👀

Oh yeah, that makes sense! We can just let this PR sit for now, in that case 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants