-
Notifications
You must be signed in to change notification settings - Fork 856
Added a warning that prisma-client-js will be deprecated in v7
#7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
WalkthroughAdds a deprecation warning admonition to the prisma-client-js generator section in the Prisma schema documentation. The warning notifies users that prisma-client-js will be deprecated in Prisma ORM 7 in favor of prisma-client, with a reference link for additional details. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
Deploying docs with
|
| Latest commit: |
7d6602b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58b27861.docs-51g.pages.dev |
| Branch Preview URL: | https://prisma-client-js-deprecation.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/200-orm/100-prisma-schema/10-overview/03-generators.mdx (1)
27-31: Minor: Consider improving link text clarity.The link text reads "read more" immediately followed by a link with the same intent. Slightly more specific text (e.g., "learn about the transition" or "explore the migration guide") would better signal what users will find when clicking, improving UX.
Example improvement:
- In Prisma ORM 7, `prisma-client-js` will be deprecated in favor of `prisma-client`. For more information, [read more](https://www.prisma.io/blog/rust-free-prisma-orm-is-ready-for-production). + In Prisma ORM 7, `prisma-client-js` will be deprecated in favor of `prisma-client`. For more information, [see the migration guide](https://www.prisma.io/blog/rust-free-prisma-orm-is-ready-for-production).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/100-prisma-schema/10-overview/03-generators.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-09T21:32:50.340Z
Learnt from: aidankmcalister
PR: prisma/docs#7167
File: content/900-ai/prompts/astro.mdx:84-84
Timestamp: 2025-10-09T21:32:50.340Z
Learning: The `npx prisma init` command supports the following flags: `--db` (shorthand for `--datasource-provider prisma+postgres`), `--output` (specifies output location for generated client), `--generator-provider` (defines the generator provider), `--datasource-provider`, `--url`, `--preview-feature`, and `--with-model`. These are documented valid CLI options for Prisma init command.
Applied to files:
content/200-orm/100-prisma-schema/10-overview/03-generators.mdx
📚 Learning: 2025-08-11T09:40:55.237Z
Learnt from: ankur-arch
PR: prisma/docs#7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.
Applied to files:
content/200-orm/100-prisma-schema/10-overview/03-generators.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Check links
🔇 Additional comments (1)
content/200-orm/100-prisma-schema/10-overview/03-generators.mdx (1)
27-31: Deprecation warning placement and messaging are clear and well-positioned.The warning is strategically placed right after the section heading and uses consistent admonition syntax with the rest of the documentation. The statement that
prisma-client-jswill be deprecated in favor ofprisma-clientaligns with Prisma's roadmap, and the context that Prisma Client will require an output path in version 7 reinforces the need for this migration guidance.
Summary by CodeRabbit