Fix: Remove quotes from multiple languages in tutorialCategories #939
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes quotes from YAML values to fix template engine parsing - Resolves sidebar translation issue where categories stayed in English - Fixes follow-up from PR processing#931"
|
Hi @marioguzzzman thanks so much for raising this! Right now, I'm not able to reproduce the issue - eg I go to https://p5js.org/es/tutorials/ and I see: 
This is the current live build, which does have a mix of quotes. (Similarly for ko/hi/zh-Hans) |
|
@ksen0 You are right. Now, it seems like the sidebar is displaying the languages correctly. Before, as showed in my screenshots, it was not... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@perminder-17 @Homaid @ksen0
Following this discussion> #931 (comment)
I think the quotes create issues that go beyond consistency.
Issue identified: YAML values with quotes are not being processed correctly by the template engine.
From live website:
The
tutorialCategoriessection is using quoted values while other working sections use unquoted values. This suggests the p5.js template engine has a parsing issue with quoted YAML strings.Proposed solution: Remove quotes from all
tutorialCategoriesvalues.Screenshots showing the issue across different languages: