Skip to content

Conversation

adi-ray
Copy link
Contributor

@adi-ray adi-ray commented Aug 23, 2025

Description:

PR updates the outdated contributor documentation which was still referencing the old workflow using npm run docs and npm run docs:dev commands within the p5.js repository.

Note

Please review the English content changes first. Once approved, I'll be happy to update the other language versions accordingly.

Fixes #924

notthewave and others added 30 commits February 20, 2025 11:15
Fully unmount sketches that go out of frame
Add libraries, fix bug with old featured ones not getting cycled
Updated description and `sourceURL`.
reshma045 and others added 23 commits July 23, 2025 18:29
…rchBar-ouline

Fixed LinkButton and SearchForm outline
Fix: Use import for fes.svg instead of copying to public
Fix: Improve image visibility in dark mode by inverting images
replace the open call submission promo with the old-site banner alert
Add missing translations for tutorial section headings
Add missing tutorialCategories.education-resources to en.yaml
- Updated `getCurationSketches` in `src/api/OpenProcessing.ts` to:
  - Remove hardcoded fetch limit to retrieve all curated sketches
  - Support fetching from both 2024 and 2025 curation IDs
  - Add `curation` property to each sketch for filtering and ordering
- Updated `src/pages/community.astro` to:
  - Use a priority ID list to select and order featured sketches
  - Ensure no duplicate sketches appear in the display
- Added high-resolution images for 2025 curated sketches

Signed-off-by: MissTipo <[email protected]>
Sync curated sketches update and filter cleanup from 2.0 into main
Fix Markdown backtick escaping in Variables and Change tutorial
@ksen0 ksen0 requested a review from perminder-17 August 25, 2025 21:24
@perminder-17 perminder-17 changed the base branch from main to 2.0 August 26, 2025 21:42
@perminder-17 perminder-17 changed the base branch from 2.0 to main August 26, 2025 21:42
Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adi-ray , the reference generation instructions was supposed to be updated in the 2.0 branch.

Actually we have deployed the 2.x version with 2.0 branch of p5.js-website and all 1.x versions are deployed with the main branch. Can you please re-target your PR according to the 2.0 branch?

Steps:

  1. In the PR, click Edit -> change the base from main to 2.0 -> Save.

Locally:

git fetch origin
git checkout update-doc
git rebase origin/2.0
git push --force-with-lease

@adi-ray adi-ray changed the base branch from main to 2.0 August 27, 2025 05:20
@adi-ray
Copy link
Contributor Author

adi-ray commented Aug 27, 2025

Hi @adi-ray , the reference generation instructions was supposed to be updated in the 2.0 branch.

Actually we have deployed the 2.x version with 2.0 branch of p5.js-website and all 1.x versions are deployed with the main branch. Can you please re-target your PR according to the 2.0 branch?

Steps:

  1. In the PR, click Edit -> change the base from main to 2.0 -> Save.

Locally:

git fetch origin
git checkout update-doc
git rebase origin/2.0
git push --force-with-lease

Hi! Thanks for the clarification about targeting the 2.0 branch. I'm running into some rebase conflicts.

Lemme just create a fresh PR directly against the 2.0 branch instead.

@adi-ray adi-ray closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reference generation/preview instructions to new p5.js 2.0 fork workflow