-
Notifications
You must be signed in to change notification settings - Fork 174
Update reference generation instructions for p5.js 2.0 fork workflow #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-main2 Update contributors list
This reverts commit 568a8b8.
Fully unmount sketches that go out of frame
Add libraries, fix bug with old featured ones not getting cycled
FPS library
Signed-off-by: shiva <[email protected]>
Updated description and `sourceURL`.
…th no args and memoize getCurationSketches
…come from getSketch
…rchBar-ouline Fixed LinkButton and SearchForm outline
Fix: Use import for fes.svg instead of copying to public
Fix: Improve image visibility in dark mode by inverting images
…banner alert Signed-off-by: MissTipo <[email protected]>
replace the open call submission promo with the old-site banner alert
…js-website into fix-i18n-translations
Add missing translations for tutorial section headings
Add missing tutorialCategories.education-resources to en.yaml
- Updated `getCurationSketches` in `src/api/OpenProcessing.ts` to: - Remove hardcoded fetch limit to retrieve all curated sketches - Support fetching from both 2024 and 2025 curation IDs - Add `curation` property to each sketch for filtering and ordering - Updated `src/pages/community.astro` to: - Use a priority ID list to select and order featured sketches - Ensure no duplicate sketches appear in the display - Added high-resolution images for 2025 curated sketches Signed-off-by: MissTipo <[email protected]>
Signed-off-by: MissTipo <[email protected]>
Sync curated sketches update and filter cleanup from 2.0 into main
Fix Markdown backtick escaping in Variables and Change tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adi-ray , the reference generation instructions was supposed to be updated in the 2.0 branch.
Actually we have deployed the 2.x version with 2.0
branch of p5.js-website
and all 1.x versions are deployed with the main
branch. Can you please re-target your PR according to the 2.0
branch?
Steps:
- In the PR, click Edit -> change the base from main to 2.0 -> Save.
Locally:
git fetch origin
git checkout update-doc
git rebase origin/2.0
git push --force-with-lease
Hi! Thanks for the clarification about targeting the 2.0 branch. I'm running into some rebase conflicts. Lemme just create a fresh PR directly against the 2.0 branch instead. |
Description:
PR updates the outdated contributor documentation which was still referencing the old workflow using
npm run docs
andnpm run docs:dev
commands within the p5.js repository.Note
Please review the English content changes first. Once approved, I'll be happy to update the other language versions accordingly.
Fixes #924