-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Auto-link / Close Issues for 2.0 PRs (p5.js & p5.js-website) #8025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.0
Are you sure you want to change the base?
Conversation
- Introduced modifyMaterialShader, modifyFilterShader, modifyNormalShader, modifyColorShader, and modifyStrokeShader functions - Added documentation file 'modifymethod shortcut.md' explaining usage and benefits
with: | ||
script: | | ||
const prBody = context.payload.pull_request.body; | ||
const issueRegex = /(Fixes|Resolves|Closes)\s+#(\d+)/gi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: consider making more flexible? Eg /(close[sd]?|fix(e[sd])?|resolve[sd]?)[:\s]*#(\d+)/gi
or something like that to more match the level of flexibility that happens on the main branch. While this is a bit more complex, I think matching behavior between these branches might be worth doing, what do you thi nk @perminder-17 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah, yes, that sounds great to me and also very flexible as well. It would help ensure consistency with the main branch’s behavior.
|
||
jobs: | ||
close_issues: | ||
if: github.event.pull_request.merged == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Relates to #7975 |
I've put together https://github.com/processing/branch-pr-close-issue. If it looks good we can transition the inline script over to that action repo. The main difference would be in the regex, I'm not 100% sure what the matching behavior of GitHub's auto link feature is but I've limited it to a more restrictive set:
Only the ticked ones above will match, the others are for illustrative purposes. The other keywords and variations still matches as well, this only concerns the part between the keyword and the issue tag. |
Resolves #7989
Changes:
Added a yaml file which listens for maintainers comments to close and merge pul request.
Screenshots of the change:


I was cleaning up my local git branch and accidentally deleted the branch I was using for testing, so the original pull request also got deleted.
Hence again opening the pull request.
PR Checklist
npm run lint
passes