New links in "Help" menu for issues and forum #1210
Conversation
|
Added no tests btw. Works bug-free on MacOS 15.6 and should work universally. |
lassevonpfeil
changed the title
There was a problem hiding this comment.
Hi! Great work on this! I am curious about which version of Java you are using. We use Eclipse Temurin 17. I believe if you set that SDK then you will see that desktop.browse() will throw an exception.
here is an example in the file of the pattern you'll want to follow:
item = new JMenuItem(Language.text("menu.help.getting_started"));
item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url")));
menu.add(item);
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
|
|
There was a problem hiding this comment.
Are these necessary anymore? If not please remove, and then this is ready to be approved! 🎉
|
|
||
| // Ask on the Forum link opener | ||
| item = new JMenuItem(Language.text("menu.help.ask")); | ||
| item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url"))); |
There was a problem hiding this comment.
Hey @lassevonpfeil. I just caught while testing: the URL here should have been menu.help.ask.url instead of menu.help.getting_started.url. Would you mind making another PR for this small fix? Thanks! cc @catilac
There was a problem hiding this comment.
Hi @lassevonpfeil just checking in. Would you be able to confirm whether or not you'll be able to make this small PR?
There was a problem hiding this comment.
Hi, sorry for the delay. Of course, will work on it asap.
There was a problem hiding this comment.
No problem at all! Just wanted to check in. Thank you so much, @lassevonpfeil :)
Added two links to the help menu bar. Opens either processing forum or GitHub issues tab in standard browser when clicked. Resolves Issue #1208
Implemented the new features in JavaEditor.java and also provided German language support.
Used Desktop.getDesktop() and then Desktop.browse(oURL) to follow the link.
I Placed the MenuItems between "Download official reference" and "library reference".
I will change the code ASAP when somethings bugging or the I messed up with the style guidelines.