Skip to content

Conversation

@chipspeak
Copy link
Contributor

Testing unit and e2e test fix

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 75.77093% with 55 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (f9f8671) to head (ef9c6c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/cluster/cluster.py 70.83% 35 Missing ⚠️
src/codeflare_sdk/ray/job/job.py 73.97% 19 Missing ⚠️
src/codeflare_sdk/ray/rayjobs/rayjob.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   92.47%   90.12%   -2.36%     
==========================================
  Files          24       27       +3     
  Lines        1396     1620     +224     
==========================================
+ Hits         1291     1460     +169     
- Misses        105      160      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants