-
Notifications
You must be signed in to change notification settings - Fork 56
feat(RHOAIENG-29330):Deny RayCluster creation with Ray Version mismatches #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHOAIENG-29330):Deny RayCluster creation with Ray Version mismatches #881
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ray-jobs-feature #881 +/- ##
====================================================
- Coverage 93.65% 93.57% -0.08%
====================================================
Files 20 21 +1
Lines 1717 1774 +57
====================================================
+ Hits 1608 1660 +52
- Misses 109 114 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
49e7d69
to
3965a7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small changes but this is great work @LilyLinh well done :)
6d8b730
to
7327753
Compare
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for making those changes @LilyLinh ! Fantastic work :) lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
3489a6b
into
project-codeflare:ray-jobs-feature
Issue link
Jira
What changes have been made
This PR implements Ray version validation to prevent compatibility issues between the CodeFlare SDK and user-specified runtime images.
Solution: Added automatic Ray version detection and validation during cluster configuration:
extract_ray_version_from_image()
parses Ray versions from various image name formats (e.g.,ray:2.47.1
,quay.io/modh/ray:2.47.1-py311-cu121
)validate_ray_version_compatibility()
compares runtime image Ray version against SDK version (2.47.1)ClusterConfiguration.__post_init__()
Verification steps
Build the SDK, test its functionality in a notebook.
image="quay.io/modh/ray:2.47.1-py311-cu121"
, the cluster is created and up successfully; when using a different Ray version ( e.g.,image="quay.io/modh/ray:2.46.1-py311-cu121"
), it should show an error message.Checks