Skip to content

RHOAIENG-26488: Add Lifecycled RayCluster demo notebook for RayJobs #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ray-jobs-feature
Choose a base branch
from

Conversation

kryanbeane
Copy link
Contributor

Issue link

RHOAIENG-26488

What changes have been made

Added demo notebook for lifecycling a RayCluster via Rayjob submission

Verification steps

Replace the values and run the notebook, both locally and from within an Openshift cluster.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2025

@kryanbeane: This pull request references RHOAIENG-26488 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-26488

What changes have been made

Added demo notebook for lifecycling a RayCluster via Rayjob submission

Verification steps

Replace the values and run the notebook, both locally and from within an Openshift cluster.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dimakis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (5a77f7b) to head (5d2eb3a).

Additional details and impacted files
@@                Coverage Diff                @@
##           ray-jobs-feature     #883   +/-   ##
=================================================
  Coverage             93.65%   93.65%           
=================================================
  Files                    20       20           
  Lines                  1717     1717           
=================================================
  Hits                   1608     1608           
  Misses                  109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane marked this pull request as ready for review August 14, 2025 11:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025
@openshift-ci openshift-ci bot requested review from chipspeak and szaher August 14, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants