Skip to content

Conversation

kryanbeane
Copy link
Contributor

Issue link

N/A

What changes have been made

Updated auth guide in notebooks

Verification steps

Run the steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from chipspeak and dimakis August 29, 2025 14:41
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (cb5589c) to head (bc463f1).
⚠️ Report is 2 commits behind head on ray-jobs-feature.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           ray-jobs-feature     #894      +/-   ##
====================================================
+ Coverage             93.45%   93.48%   +0.03%     
====================================================
  Files                    21       21              
  Lines                  1910     1889      -21     
====================================================
- Hits                   1785     1766      -19     
+ Misses                  125      123       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane force-pushed the fix-auth-in-notebooks branch 2 times, most recently from 739f602 to 25853ef Compare September 1, 2025 10:26
@pawelpaszki
Copy link
Contributor

@kryanbeane I think notebook 4 still contains incorrect submit()instead of status(). can you change that please (both instruction and command)? can you also update the namespace in notebook 4 to be "your-namespace" or similar please? when I started the job in the rhods-notebook, its status continued to be unknown.

Once these changes are applied - it looks good

@kryanbeane kryanbeane force-pushed the fix-auth-in-notebooks branch from 25853ef to bc463f1 Compare September 4, 2025 15:11
@kryanbeane
Copy link
Contributor Author

@pawelpaszki done thank you

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 47122ee into project-codeflare:ray-jobs-feature Sep 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants