-
Notifications
You must be signed in to change notification settings - Fork 57
task(RHOAIENG-33045): Update Runtime image SHAs for PY312 #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(RHOAIENG-33045): Update Runtime image SHAs for PY312 #895
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
- Coverage 92.47% 92.47% -0.01%
==========================================
Files 24 25 +1
Lines 1382 1395 +13
==========================================
+ Hits 1278 1290 +12
- Misses 104 105 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/hold |
E2E has failed due to an assertion in the
Given just how small the difference is, allowing a more approximate value might be a better solution than a hard-coded one. |
I've gotten the same error multiple times with the same 0.0000000000008% difference in the assertion. I've updated the value to match the Python 3.12 difference just to see if the tests pass etc. I don't think there'd be any harm in keeping this new value as we won't need to test Python 3.11 in this test going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great improvements to the runtime image selection thanks Pat, lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane, pawelpaszki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7068ae9
to
a78da26
Compare
/unhold |
Signed-off-by: Pat O'Connor <[email protected]>
a78da26
to
3847778
Compare
/lgtm |
2bb2376
into
project-codeflare:main
Issue link
Jira Link
What changes have been made
Updated CodeFlare SDK runtime image defaults to include the new Python 3.12 image. This has also been updated in the demo notebooks where referenced.
Additionally, I've moved our supported versions logic to
constants.py
as I feel this is a more intuitively central location for this. Similarly, a newutils.py
file extracts the correct runtime image version to pull in place of the less central existing logic.Verification steps
whl
file by runningpoetry build
.pip install <path_to_your_whl> --force-reinstall
python3 --version
to verify that it is using Python 3.12.9.Checks