RHOAIENG-27792: Add stop, resubmit, & delete. Auto tear down config maps. E2Es

[kryanbeane]

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job and let it run to completion

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted

Verification steps

TODO

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.19%. Comparing base (47122ee) to head (1637cfd).
⚠️ Report is 3 commits behind head on ray-jobs-feature.

Files with missing lines	Patch %	Lines
src/codeflare_sdk/ray/rayjobs/rayjob.py	97.29%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           ray-jobs-feature     #896      +/-   ##
====================================================
+ Coverage             93.48%   94.19%   +0.70%     
====================================================
  Files                    21       21              
  Lines                  1889     1911      +22     
====================================================
+ Hits                   1766     1800      +34     
+ Misses                  123      111      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pawelpaszki]

@kryanbeane will you modify existing e2e test(s) to include the new functionality?

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

TODO

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHOAIENG-27792 which is a valid jira issue.

In response to this:

Issue link

RHOAIENG-27792

What changes have been made

• Added job.stop(), job.resubmit(), and job.delete()
• Added logic to automatically tear down the training script config map when a Training job is deleted
• Updated E2E test

Verification steps

• Follow this guided notebook to submit a job and run the below:

• Stop / Suspend the job

job.stop()

Verify manually that the job has been suspended (spec.suspend = true) and that the RayCluster was torn down

• Resubmit the Job and let it run to completion

job.resubmit()

• Delete the Job CR

job.delete()

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawelpaszki]

I have verified the changes while running the notebook and executed the test locally (with increased timeout - as per my comment). it works good. Thanks!

[kryanbeane]

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pawelpaszki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kryanbeane]

/unhold