Skip to content

Refactor Dockerfile base on official best practices #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor Dockerfile base on official best practices #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b95bd4
Use COPY instead of ADD for files and folders in Dockerfile
PeterDaveHello May 20, 2020
78761cf
Use arguments JSON notation for CMD arguments
PeterDaveHello May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN yum install -y --setopt=tsflags=nodocs npm && \
yum clean all

WORKDIR /opt/dockerfile_lint
ADD . .
COPY . .
RUN npm install && \
ln -s /opt/dockerfile_lint/bin/dockerfile_lint /usr/bin/dockerfile_lint

Expand All @@ -21,4 +21,4 @@ RUN mkdir /sample_rules && \
WORKDIR /root/
LABEL RUN docker run -it --rm --privileged -v `pwd`:/root/ -v /var/run/docker.sock:/var/run/docker.sock --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE dockerfile_lint

CMD /bin/bash
CMD ["/bin/bash"]