Add custom health check endpoint #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PovilasV1
force-pushed
the
feat/add_health_check_path
branch
from
d8bf776 to
a0d529d
Compare
Signed-off-by: Povilas Vaitkus <[email protected]>
PovilasV1
force-pushed
the
feat/add_health_check_path
branch
from
a0d529d to
d5394a7
Compare
|
cc: @SuperQ @kgeckhart |
3 tasks
|
The project has never had a health endpoint just the landing page + metrics and it looks like v0.17.0 brought in, prometheus/exporter-toolkit#261, changing the landing page behavior. Perhaps it's better to change the helm chart so health is routed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #386
After
0.17.0/healthreturns404. The/healthis also used in the helm chart for readiness and liveness probes.