Migrated Java codegen to use IsOss() global instead of plumbing this setting through all the APIs.
#23515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_806410750
branch
11 times, most recently
from
c05d396 to
efb4e9a
Compare
…s setting through all the APIs. This will allow the APIs in compiler/java/names.h to be made fully correct without needing to add an `Options` parameter. This setting should never need to vary within a process, so there is no need to plumb the setting through all of the APIs. PiperOrigin-RevId: 808345038
copybara-service
bot
force-pushed
the
test_806410750
branch
from
efb4e9a to
f526514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated Java codegen to use
IsOss()global instead of plumbing this setting through all the APIs.This will allow the APIs in compiler/java/names.h to be made fully correct without needing to add an
Optionsparameter.This setting should never need to vary within a process, so there is no need to plumb the setting through all of the APIs.