Add internal_metadata_locator.h to provide offset-based access to InternalMetadata.
#23521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_807402335
branch
from
f38c847 to
d64acf0
Compare
…InternalMetadata`. This new header defines `InternalMetadataOffset` and `InternalMetadataResolver` to allow locating a message's `_internal_metadata_`, or any other class's `internal_metadata_` member, from a field's address using a precomputed offset. This will allow us to implement `GetArena()` for message fields without needing to store a copy of the message Arena* in each field that has a `GetArena()` method. PiperOrigin-RevId: 807402335
copybara-service
bot
force-pushed
the
test_807402335
branch
from
d64acf0 to
bf6079b
Compare
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
internal_metadata_locator.hto provide offset-based access toInternalMetadata.This new header defines
InternalMetadataOffsetandInternalMetadataResolverto allow locating a message's_internal_metadata_, or any other class'sinternal_metadata_member, from a field's address using a precomputed offset. This will allow us to implementGetArena()for message fields without needing to store a copy of the message Arena* in each field that has aGetArena()method.