Introducing a Load Switch Manager #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Michael Pham <[email protected]>
Mikefly123
added
the
Vibe Coded
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new LoadSwitchManager system to provide a uniform interface for controlling power flow to different satellite components through load switches.
- Implements a generic LoadSwitchManager class with enable, disable, reset, and status checking functionality
- Defines a protocol interface for load switch management to ensure consistent API design
- Includes comprehensive unit tests covering normal operations and error conditions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
circuitpython-workspaces/flight-software/src/pysquared/protos/loadswitch.py |
Defines the LoadSwitchManagerProto protocol interface |
circuitpython-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/loadswitch_manager.py |
Implements the LoadSwitchManager class with power control methods |
circuitpython-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/__init__.py |
Package initialization file for the manager module |
circuitpython-workspaces/flight-software/src/pysquared/hardware/load_switch/__init__.py |
Package initialization file for the load_switch module |
cpython-workspaces/flight-software-unit-tests/src/unit-tests/hardware/load_switch/manager/test_loadswitch_manager.py |
Comprehensive unit tests for the LoadSwitchManager functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
circuitpython-workspaces/flight-software/src/pysquared/protos/loadswitch.py
Outdated
Show resolved
Hide resolved
circuitpython-workspaces/flight-software/src/pysquared/protos/loadswitch.py
Outdated
Show resolved
Hide resolved
circuitpython-workspaces/flight-software/src/pysquared/protos/loadswitch.py
Outdated
Show resolved
Hide resolved
...-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/loadswitch_manager.py
Outdated
Show resolved
Hide resolved
...-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/loadswitch_manager.py
Outdated
Show resolved
Hide resolved
...-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/loadswitch_manager.py
Outdated
Show resolved
Hide resolved
...-workspaces/flight-software/src/pysquared/hardware/load_switch/manager/loadswitch_manager.py
Outdated
Show resolved
Hide resolved
…loadswitch.py Co-authored-by: Copilot <[email protected]>
…pysquared into mike-loadswitch-proto
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…d into mike-loadswitch-proto
…d into mike-loadswitch-proto
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes out some of the work that was originally in #269. With this new
loadswitch_managerusers will be able to have a uniform interface for interacting with load switches that control the power flowing to different parts of the satellite!How was this tested