-
Notifications
You must be signed in to change notification settings - Fork 4
Add several include files and functions to make the build succeed #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@rasbt I am Bunsho Koyano, a research student at the University of Tokyo. I made a pull request for ProFlex. If you could respond, I would appreciate it very much. Best regards |
|
Thanks for the PR, @KoyanoBunsho . I should add that this repository is in archive mode and not actively maintained anymore. However, I just gave it a try and the ProFlex compiles just fine with your changes. However, I then also tried to compile the original, and it works fine on my computer, too. So, I am actually unsure whether this change is necessary. Maybe we can just leave this PR open and in case someone else has issues with the original code, we can consider this alternative and see if it can solve the potential issue. |
|
@rasbt
I see. Maybe my specific environment could cause the compilation error.
Your suggestion sounds good. Thank you so much! Best regards. |
Dear ProFlex developers.
My background
PR Objective
What I add
Because I am not an expert in this software, I may be wrong, and these changes may not be necessary.
If you could respond, I would appreciate it very much.
Best regards