Skip to content

Conversation

@KoyanoBunsho
Copy link

Dear ProFlex developers.

My background

  • I am Bunsho Koyano, a research student at the University of Tokyo. Currently, I am trying to use ProFlex for the flexibility analysis of proteins.

PR Objective

  • I found the latest ver. of Proflex does not successfully build

What I add

  • include <stdio.h> for connect.h, graphs.h, postscript.h, text_output.h,
  • #include <string.h> for postscript.c
  • The functions swap_colors, quick_sort for text_output.c

Because I am not an expert in this software, I may be wrong, and these changes may not be necessary.
If you could respond, I would appreciate it very much.

Best regards

@KoyanoBunsho
Copy link
Author

@rasbt
Dear Dr. Sebastian Raschka

I am Bunsho Koyano, a research student at the University of Tokyo. I made a pull request for ProFlex. If you could respond, I would appreciate it very much.

Best regards
Bunsho Koyano

@rasbt
Copy link
Member

rasbt commented Dec 21, 2021

Thanks for the PR, @KoyanoBunsho . I should add that this repository is in archive mode and not actively maintained anymore. However, I just gave it a try and the ProFlex compiles just fine with your changes. However, I then also tried to compile the original, and it works fine on my computer, too. So, I am actually unsure whether this change is necessary.

Maybe we can just leave this PR open and in case someone else has issues with the original code, we can consider this alternative and see if it can solve the potential issue.

@KoyanoBunsho
Copy link
Author

@rasbt
Thank you for your kind response!

I then also tried to compile the original, and it works fine on my computer, too. So, I am actually unsure whether this change is necessary.

I see. Maybe my specific environment could cause the compilation error.

Maybe we can just leave this PR open and in case someone else has issues with the original code, we can consider this alternative and see if it can solve the potential issue.

Your suggestion sounds good. Thank you so much!

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants