Fixed streamUpdatesOn on Message #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original Message.streamUpdatesOn implementation created excessive resubscribe cycles when called multiple times for messages on the same channel because a SubscriptionSet was created and subscribe() was called for each execution. To fix this, we use global listeners (which receive events from ANY subscription, not just their own) combined with reference counting. We track whether a subscription already exists for a channel - if yes, we skip the redundant subscribe() call; if no, we create a SubscriptionSet and call subscribe(). The global listener receives events as long as SOMEONE has subscribed to the channel, allowing multiple streamUpdatesOn calls to share a single subscription.
marcin-cebo
requested review from
jakub-grzesiowski and
jguz-pubnub
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Message.streamUpdatesOn implementation created excessive resubscribe cycles when called multiple times for messages on the same channel because a SubscriptionSet was created and subscribe() was called for
each execution. FIx is to track whether a subscription already exists for a channel - if
yes, we skip the redundant subscribe() call; if no, we create a Subscription and call subscribe(). When close() method is called on AutoClosable that is returned when calling streamUpdatesOn only when there is last reference to the subscription unsubscribe() method is called.
For each execution of Message.streamUpdatesOn we create