Skip to content

Conversation

MastroDiego
Copy link

This update introduces a programmable-length FIFO job queue to the source and sink modules. The queue allows jobs to be stored and processed sequentially, enabling autonomous job management. Each module can now execute jobs without direct control, improving flexibility in job handling.

@FrancescoConti FrancescoConti changed the title Dg/hci modified Introduce job queues for source/sink modules Jan 16, 2025
@FrancescoConti
Copy link
Member

Hi Diego, thanks for the PR! Generally looks very good, I left you a few comments, all of them minor.
How are you testing this, on RedMulE/SoftEx/other?

@MastroDiego
Copy link
Author

Hi Francesco, thanks for your feedback! I have tested this on HWPE-Datamover only to validate edge cases. The plan is to implement it on Neureka.

@FrancescoConti
Copy link
Member

OK, I suggest to push the tests to HWPE-Datamover and prepare a PR there, it could be useful.

@MastroDiego
Copy link
Author

I made some quick and not so pretty changes in the Datamover (I increased the number of registers in the control slave to simulate multiple jobs offloading at the same time). That's why Andrea and I initially thought it wouldn't make sense to open a PR. But if needed, I can clean things up and make it more structured.

@FrancescoConti
Copy link
Member

Maybe open a draft PR as is, just not to lose track ;)

@@ -33,7 +33,7 @@ sources:
- rtl/core/hci_core_mux_ooo.sv
- rtl/core/hci_core_r_valid_filter.sv
- rtl/core/hci_core_r_id_filter.sv
- rtl/core/hci_core_source.sv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this line back: it is not possible to use the old hci_core_source at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants