Migrate to N-API #10
Closed
Migrate to N-API #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
Merged
|
Closing this because we finally migrated to N-API in #18 after several attempts. All of these earlier PRs that attempted the N-API migration were important to consult, as was tree-sitter-node#190 — serving as an example of how to achieve context awareness by maintaining context-specific constructors as addon data. @mauricioszabo, if the “Adding a setter for Thanks! |
|
Yes, it is, I'll open against current master, thanks for the info :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work on this PR: #5
scorein subsequent matcher