Skip to content

fix: allow plus signs in ppa #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow plus signs in ppa #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/ppa.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
}

# Validate the resource name
if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.]+)$/ {
if $name !~ /^ppa:([a-zA-Z0-9\-_.+]+)\/([a-zA-z0-9\-_.+]+)$/ {
fail("Invalid PPA name: ${name}")
}

Expand Down
2 changes: 2 additions & 0 deletions spec/defines/ppa_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ def ppa_exec_params(user, repo, distro = 'trusty', environment = [])
'ppa:foo/bar1.0',
'ppa:foo10/bar10',
'ppa:foo-/bar_',
'ppa:foo/bar+',
'ppa:foo+/bar',
].each do |value|
describe 'valid resource names' do
let :facts do
Expand Down