sources format and ensure => absent fails #1243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```puppet
apt::source{
ensure => absent,
source_format => sources,
```
produces a compile error every time.
```
Puppet::PreformattedError:
Evaluation Error: Error while evaluating a Resource Statement, Apt::Setting[sources-my_source]: parameter 'content' expects a value of type Undef or String[1], got String (file: /home/steve/GIT/puppetlabs-apt/spec/fixtures/modules/apt/manifests/source.pp, line: 363) on node legion.lan
```
traylenator
requested review from
bastelfreak,
smortex and
a team
as code owners
traylenator
added a commit
to traylenator/puppet-cvmfs
that referenced
this pull request
Aug 15, 2025
smortex
reviewed
Aug 18, 2025
Comment on lines
+351
to
+352
| $header = '# no content not permitted, ignored for absent case' | ||
| $source_content = '# not content not permitted, ignored for absent case' |
There was a problem hiding this comment.
I struggle to process the double negation, and had to check the code to understand that these too variables are serialized as strings, concatenated, and send to some Optional[String[1]] parameter.
Can we instead act where this happen, on line 365? Something like:
content => if $header or $source_content { "${header}${source_content}" } else { undef },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
apt::source{ ensure => absent, source_format => sources, }produces a compile error every time.