Skip to content

Conversation

@gagara
Copy link

@gagara gagara commented Feb 9, 2025

Escape " and \n characters in BalloonEval selection.
Fixes #460

@puremourning
Copy link
Owner

This change is Reviewable

@puremourning
Copy link
Owner

Thanks for sending a patch!

Please can you elaborate on the rationale for this approach and how you tested it and confirmed it works and doesn't regress?

@gagara
Copy link
Author

gagara commented Feb 9, 2025

If we consider following code snippet

        String s = "line1" +
            "line2";

if we try to evaluate either "line1" or both "line1" + "line2" then we will get an error (see #460).
This fix should allow mentioned evaluations.
Unit tests are green, that is why I expect no regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VimspectorBalloonEval throws error when evaluating expression with quotes

2 participants