-
Notifications
You must be signed in to change notification settings - Fork 177
Don't display frame ID on stack trace #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Don't display frame ID on stack trace #933
Conversation
9517ce5 to
c252f5f
Compare
puremourning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @samisalreadytaken)
python3/vimspector/stack_trace.py line 684 at r1 (raw file):
self._buf, ' {0}@{1}:{2}'.format( frame[ 'name' ], source[ 'name' ],
Fix formatting.
|
Thanks! Just a nit and we can merge |
c252f5f to
91ad657
Compare
|
Should the lines be indented for clarity? |
Hmm. Yeah maybe. The old id served as a visual marker but now we have a little ambiguity. Try it. See what you think. |
91ad657 to
20602bd
Compare
|
I think it's better with it, also more consistent with the "tree" style expand. |
|
Agreed |
Frame ID is an opaque data that does not concern the end user. Different servers assign them differently. For example this python server has IDs 3,2,12,24; this c server has [1000,1007]; and my debugger simply increments an index with no order.
Don't print this internal info to save screen space and prevent potential confusion.