Refactor and consolidate mixins #1564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the mixin architecture by introducing consolidated mixin classes for each media type (MovieMixins, ShowMixins, etc.), significantly reducing import complexity across the codebase while maintaining identical functionality.
Key changes:
- Created 12 new consolidated mixin classes in
plexapi/mixins.py(MovieMixins, ShowMixins, SeasonMixins, EpisodeMixins, ClipMixins, ArtistMixins, AlbumMixins, TrackMixins, PhotoalbumMixins, PhotoMixins, CollectionMixins, PlaylistMixins) - Updated all media type class definitions to use consolidated mixins instead of listing individual mixins
- Enhanced type annotation in
_parseQueryFeedmethod
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plexapi/mixins.py | Adds 12 new consolidated mixin classes and improves type annotation for filtersDict |
| plexapi/video.py | Updates Movie, Show, Season, Episode, and Clip classes to use consolidated mixins |
| plexapi/audio.py | Updates Artist, Album, and Track classes to use consolidated mixins |
| plexapi/photo.py | Updates Photoalbum and Photo classes to use consolidated mixins |
| plexapi/collection.py | Updates Collection class to use consolidated mixins |
| plexapi/playlist.py | Updates Playlist class to use consolidated mixins |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor mixins for each media type to reduce number of imports.
Checklist: