Skip to content

Review formKey calculation for data validation cache #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Review formKey calculation for data validation cache #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions server/src/main/webapp/public/resources/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,8 @@ PWM_MAIN.pwmFormValidator = function(validationProps, reentrant) {

// check if data is in cache, if it is just process it.
var formData = readDataFunction();
var formKey = "";
for (var key in formData) {formKey += formData[key] + "-";}
var formDataString = JSON.stringify(formData) ;
var formKey = formDataString;

{
var cachedResult = PWM_VAR['validationCache'][formKey];
Expand Down Expand Up @@ -1263,8 +1263,6 @@ PWM_MAIN.pwmFormValidator = function(validationProps, reentrant) {
}, 5);
}

var formDataString = JSON.stringify(formData) ;

if (CONSOLE_DEBUG) console.log('FormValidator: sending form data to server... ' + formDataString);
var loadFunction = function(data) {
PWM_VAR['validationInProgress'] = false;
Expand Down