-
-
Couldn't load subscription status.
- Fork 697
Set zip(..., strict=True) in key solver/expression tree files for len… #5241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5241 +/- ##
========================================
Coverage 98.82% 98.82%
========================================
Files 321 321
Lines 27491 27491
========================================
Hits 27169 27169
Misses 322 322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @swastim01, just one thing to clean up the changelog. Otherwise, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Set
zip(..., strict=True)in key solver/expression tree files for length safetyDescription
This PR updates the solver and expression tree files to use
zip(..., strict=True)where appropriate. This ensures that allzipoperations fail fast if input iterables have mismatched lengths, improving code safety and preventing subtle bugs.Fixes #5060
Type of change
Changelog
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #):
Important checks
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests