Skip to content

Use manylinux-entrypoint script for linux wheel builds #13253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

ngoldbaum
Copy link
Contributor

See pypa/manylinux#1825 (comment) for an explanation of why we need to use this.

PR'd separately from #12555 per #12555 (comment)

@alex
Copy link
Member

alex commented Aug 6, 2025

This makes sense and seems simple enough. My own question is: how did armv7 ever work without this??? Do you have any idea?

@ngoldbaum
Copy link
Contributor Author

Do you have any idea?

abi3 builds are considered cross-compiles, so they go through get_platform_tag() in maturin, which already accounts for this:

https://github.com/PyO3/maturin/blob/df427600d13c9b3212c453b093028cef8fad9d30/src/target/mod.rs#L347-L352

The new cp314t wheel goes through a different code path in maturin, which defers to what's in sysconfig to calculate the ABI tags.

@alex
Copy link
Member

alex commented Aug 6, 2025

Ahh, that's teh magic bit. Thanks much!

@alex alex merged commit 1e003ee into pyca:main Aug 6, 2025
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants