Skip to content

Add Support for Argon2d and Argon2i Variants #13715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 3, 2025
Merged

Add Support for Argon2d and Argon2i Variants #13715

merged 14 commits into from
Nov 3, 2025
+529 −103

Conversation

@greateggsgreg
Copy link
Contributor

@greateggsgreg greateggsgreg commented Oct 20, 2025

With the bump to OpenSSL v0.10.74, argon2d and argon2i variants are available

This PR exposes those variants for use in cryptography

alex
alex reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please send the vectors as a dedicated PR + document them in test-vectors.rst. Thanks!

@greateggsgreg greateggsgreg mentioned this pull request Oct 21, 2025
Merged
@greateggsgreg
Copy link
Contributor Author

greateggsgreg commented Oct 21, 2025

can you please send the vectors as a dedicated PR + document them in test-vectors.rst. Thanks!

@alex , happy to - submitted in PR #13720

The docs update for the test vectors is admittedly minimal, but I extracted them from the same methods as argon2id

reaperhulk
reaperhulk reviewed Oct 21, 2025
View reviewed changes
@greateggsgreg greateggsgreg force-pushed the feature/additional_argon2_variant_support branch from 707f0b4 to 07dd7a5 Compare October 22, 2025 15:49
alex
alex reviewed Oct 23, 2025
View reviewed changes
reaperhulk
reaperhulk reviewed Nov 1, 2025
View reviewed changes
@reaperhulk
Copy link
Member

reaperhulk commented Nov 3, 2025

Over the weekend we implemented derive_into on argon2id (and a bunch of other KDFs) so this will need to be rebased.

@greateggsgreg
Copy link
Contributor Author

greateggsgreg commented Nov 3, 2025

Over the weekend we implemented derive_into on argon2id (and a bunch of other KDFs) so this will need to be rebased.

Just merged the latest main and resolved the relevant conflicts. All Argon2 variant should now support derive_into

@reaperhulk reaperhulk merged commit c4f34a2 into pyca:main Nov 3, 2025
68 checks passed
@reaperhulk
Copy link
Member

reaperhulk commented Nov 3, 2025

Thanks for your work here!

@greateggsgreg greateggsgreg deleted the feature/additional_argon2_variant_support branch November 3, 2025 20:44
@h-vetinari
Copy link

h-vetinari commented Nov 5, 2025

Can't comment in #9795 anymore, but leaving a link for posterity to that and the original implementation in #11524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex left review comments

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greateggsgreg @reaperhulk @h-vetinari @alex