migrate kbkdfhmac to rust #13800
Open
migrate kbkdfhmac to rust #13800
+448
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
force-pushed
the
kdf-try-again
branch
4 times, most recently
from
4fe36d8 to
f619010
Compare
reaperhulk
force-pushed
the
kdf-try-again
branch
from
f619010 to
ec2ca6c
Compare
|
These commits can be reviewed separately to make it a bit easier to follow. The second also provides coverage since we need a test to pass an incorrect buffer size. |
alex
reviewed
Nov 4, 2025
alex
reviewed
Nov 4, 2025
| } | ||
|
|
||
| // llen will exist if fixed data is not provided | ||
| let l_val = int_to_bytes(self.length * 8, self.params.llen.unwrap()); |
There was a problem hiding this comment.
We don't ever verify the range of llen, but int_to_bytes will panic if it's too big: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=a4c1b2f7067040c7a9f906a14fe15f0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this only migrates the HMAC part there is a lot of duplication, which will be removed when CMAC gets migrated. To review the logic you'll need to look at the _KBKDFDeriver class (which isn't removed since KBKDFCMAC still depends on it)