-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable URL and binary PDF for Mistral #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pintaf Thank you! Looks like the |
I tried to use DocumentURLChunk as it was done for Image, but contrarily to Images where ImageUrl is exported by Mistral sdk, there is no export of DocumentUrl... This has been properly tested with both kinds of PDFs (binary and URL) Happy to change to [Mistral]DocumentURLChunk if you tell me how to make it work because I did not succeed... update mistral deps Update to use MistralDocumentUrlChunk fix linting added document_type fix linting again Update uv.lock
ac34a6e
to
4a40240
Compare
Hi. I added tests, but this is the first time I do tests in python, so complete n00b. In order to add the two tests for binary and URL pdf, I simply copied the tests for binary and URL images from mistral. for the binary PDF, I tried to find a really small binary PDF, and found something in here Looking forward to your remarks. |
@pintaf Thanks Loïc! |
Co-authored-by: Loïc POISOT <[email protected]>
I tried to use DocumentURLChunk as it was done for Image, but contrarily to Images where ImageUrl is exported by Mistral sdk, there is no export of DocumentUrl...
This has been properly tested with both kinds of PDFs (binary and URL)
Happy to change to [Mistral]DocumentURLChunk if you tell me how to make it work because I did not succeed...