Fix pydantic-evals panel rendering with evaluators #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1567 (comment)
I believe the issue has to do with how
to_json
works on dataclasses vs BaseModel subclasses. In particular, themodel_serializer
is being ignored for dataclasses but not forBaseModel
subclasses.Either way, making it use an adapter got the behavior back to expected, and I added a test recording the actual logfire-received attributes so we will detect if changes to this happen in the future.