Load MCP servers from file #2698
Open
+212
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
Viicos
reviewed
Aug 27, 2025
DouweM
reviewed
Aug 27, 2025
| def __get_pydantic_core_schema__(cls, _: Any, __: Any) -> CoreSchema: | ||
| return core_schema.no_info_after_validator_function( | ||
| lambda dct: MCPServerStreamableHTTP(**dct), | ||
| core_schema.typed_dict_schema({'url': core_schema.typed_dict_field(core_schema.str_schema())}), |
There was a problem hiding this comment.
We should support headers as well right?
DouweM
reviewed
Aug 27, 2025
| ] | ||
|
|
||
|
|
||
| def load_mcp_servers(config_path: str | Path) -> list[MCPServerStdio | MCPServerStreamableHTTP | MCPServerSSE]: |
There was a problem hiding this comment.
Suggested change
| def load_mcp_servers(config_path: str | Path) -> list[MCPServerStdio | MCPServerStreamableHTTP | MCPServerSSE]: | |
| def load_mcp_servers(config_path: str | Path) -> list[MCPServer]: |
There was a problem hiding this comment.
This is technically not correct given that it needs to have the __get_pydantic... thing.
DouweM
reviewed
Sep 8, 2025
| ] | ||
|
|
||
|
|
||
| def load_mcp_servers(config_path: str | Path) -> list[MCPServerStdio | MCPServerStreamableHTTP | MCPServerSSE]: |
There was a problem hiding this comment.
I'd prefer this to be a classmethod on MCPServer, as it's basically an alternative bulk constructor.
There was a problem hiding this comment.
It's a bulk operation, but I think that's exactly what merits it being its own function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to The Schema Expert (@Viicos) for the help 🙏